Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme typo #278

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Fix readme typo #278

merged 2 commits into from
Aug 13, 2020

Conversation

kimroen
Copy link
Contributor

@kimroen kimroen commented Aug 13, 2020

Updates the example in the README to pass a single argument to the custom subclass of Error instead of passing two separate arguments where the second argument would be ignored.

An alternative to this could be to expand on the HTTPError implementation in the example to set a custom message and save the response, but it's just an example and it would mean we might want to do other things too to make the examples comparable.

kimroen and others added 2 commits August 13, 2020 12:11
Updates the expample in the readme to pass a single argument to the custom subclass of `Error` instead of passing two separate arguments where the second argument would be ignored.
@sindresorhus sindresorhus changed the title Fix Error in README example Fix readme typo Aug 13, 2020
@sindresorhus sindresorhus merged commit 59dbd1d into sindresorhus:master Aug 13, 2020
@kimroen kimroen deleted the patch-1 branch August 13, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants