Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for #1389 #1390

Closed
wants to merge 2 commits into from
Closed

Add failing test for #1389 #1390

wants to merge 2 commits into from

Conversation

fleg
Copy link
Contributor

@fleg fleg commented Aug 5, 2020

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

test/https.ts Outdated Show resolved Hide resolved
]
}
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.off('warning', warningListener);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this one?

test/https.ts Outdated Show resolved Hide resolved
@@ -31,6 +31,48 @@ test('https request with ca', withServer, async (t, server, got) => {
t.is(body, 'ok');
});

test('https request with ca and afterResponse hook', withServer, async (t, server, got) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test('https request with ca and afterResponse hook', withServer, async (t, server, got) => {
test.failing('https request with ca and afterResponse hook', withServer, async (t, server, got) => {

@szmarczak
Copy link
Collaborator

#1391

@szmarczak szmarczak closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants