Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to flat config #2278

Closed
fregante opened this issue Feb 10, 2024 · 11 comments
Closed

Switch to flat config #2278

fregante opened this issue Feb 10, 2024 · 11 comments

Comments

@fregante
Copy link
Collaborator

I'm opening this tracking issue to collect related tickets.

This change blocks:

@silverwind
Copy link
Contributor

silverwind commented Mar 15, 2024

Does it have to be a "switch"? There are a number of plugins that support both configs at the same time and I think it would ease the migration.

@fregante
Copy link
Collaborator Author

fregante commented Mar 15, 2024

I think the flat config is already supported:

So this issue is to drop support for the old config. It's not something that will happen anytime soon, I suppose.

@philsherry
Copy link

ESLint v8.x end of life was October 5, 2024, so Flat config is the only way forward now.

@sindresorhus
Copy link
Owner

@fisker What do you think about doing this now? (Asking for your opinion, not for you to do the work)

@fisker
Copy link
Collaborator

fisker commented Jan 19, 2025

I'm fine with it, but should we wait for XO to get ready first?

@sindresorhus
Copy link
Owner

No, I don't want this blocked on XO.

@sindresorhus
Copy link
Owner

I'm working on this now.

@silverwind
Copy link
Contributor

silverwind commented Jan 19, 2025

ESLint v8.x end of life was October 5, 2024, so Flat config is the only way forward now.

FWIW, eslint v9 still supports the deprecated config format. It will be removed only in v10.

sindresorhus added a commit that referenced this issue Jan 19, 2025
sindresorhus added a commit that referenced this issue Jan 19, 2025
@sindresorhus
Copy link
Owner

Ok, I manually migrated to ESM and flat config now. Took almost 5 hours...

@sindresorhus
Copy link
Owner

CI is failing because snapshot test binaries differ. I suspect it's a difference since I'm on macOS and tests run on Linux. Same Node.js version though. Anyone on Linux and Windows and can try updating the snapshots with Node.js 23.6.0 locally?

@fregante
Copy link
Collaborator Author

fregante commented Jan 19, 2025

GitHub Codespaces might be an option

@fisker fisker mentioned this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants