-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow border to be optional. #88
Allow border to be optional. #88
Conversation
@sindresorhus I propose this to be 7.0.3 |
You have to update the readme and types too. |
@sindresorhus I'm not really sure what you mean by that. Empty strings are still of type string for TS so it does not change anything regarding the types from my point of view. Please let me know your thoughts. |
Your pull request title does not match the pull request description. Optional is not the same as empty string. |
This is not actually fixing what was asked in the issue. The issue asked for the We could either allow |
@sindresorhus I'm more into the 'none' option. I'll work on it asap |
@sindresorhus That needs investigation, I cannot replicate the test errors. I'm not sure what it is about. |
I will publish an update tomorrow. |
Fixes #84
Fix not being able to specify empty strings in borderStyle options.