Upgrade cli-boxes dependency
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to @sindresorhus my bad. |
No need to ;) Maintainers/owners of a repo get notified of new pull requests. |
|
Can you preserve support for using |
sindresorhus
requested changes
Oct 3, 2021
| top: '-', | ||
| bottom: '_', | ||
| left: '|', | ||
| right: '!', |
There was a problem hiding this comment.
I'm not sure what you meant there, I swapped top/bottom with left/right in the next push.
There was a problem hiding this comment.
Did you mean to use an exclamation mark instead of a |?
There was a problem hiding this comment.
No I meant to use 4 different characters.
|
Did we have anything else to change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
I updated the dependency, and modified all documentation according to the new options provided by cli-boxes v3.
I also took the time to refactor the code responsible for 'inboxing/incasing' the content into a separate function for better readability and maintainability. The tests and snapshots also have been updated.
Let me know about any desired changes !