Support plain objects #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5c03b7 to
3ba0093
Compare
3ba0093 to
f70af5c
Compare
f70af5c to
1407996
Compare
|
@sindresorhus would you mind taking a look at this? |
|
I'm on the fence about this one as it feels wrong to accept arbitrary objects, but JS is arbitrary, so I guess it's ok. |
|
This will also need readme updates. |
Duck typing FTW 🦆 |
|
Updated the README |
|
Speaking of typing, would you accept a TypeScript declarations file? |
Yup, just ensure you follow https://github.com/sindresorhus/typescript-definition-style-guide |
|
Sorry, this PR got lost in my open tabs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the idea of this module.
I currently have a lot of code that does REST or GraphQL API calls, where in error cases the API usually returns one or multiple error objects with a
messageproperty and possibly others likename,codeetc. They are of course notErrorinstances, and currently get treated asnew Error(err), which creates anErrorwith message[object Object].This PR makes it so that if the passed error is not an
Errorinstance, but an object, anErroris created witherr.messageas the message and all metadata properties copied over to theErrorobject.