Skip to content

Commit

Permalink
fix(sql): add params args to pass to the connector (#1553)
Browse files Browse the repository at this point in the history
* fix(sql): add params args to pass to the connector

* feat(sql): update version of pyproject
  • Loading branch information
ArslanSaleem authored Jan 28, 2025
1 parent 30f5dd2 commit 8f6db7b
Show file tree
Hide file tree
Showing 5 changed files with 212 additions and 140 deletions.
26 changes: 18 additions & 8 deletions extensions/connectors/sql/pandasai_sql/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from typing import Optional

import pandas as pd

from pandasai.data_loader.semantic_layer_schema import (
Expand All @@ -6,7 +8,9 @@
)


def load_from_mysql(connection_info: SQLConnectionConfig, query: str):
def load_from_mysql(
connection_info: SQLConnectionConfig, query: str, params: Optional[list] = None
):
import pymysql

conn = pymysql.connect(
Expand All @@ -16,10 +20,12 @@ def load_from_mysql(connection_info: SQLConnectionConfig, query: str):
database=connection_info.database,
port=connection_info.port,
)
return pd.read_sql(query, conn)
return pd.read_sql(query, conn, params=params)


def load_from_postgres(connection_info: SQLConnectionConfig, query: str):
def load_from_postgres(
connection_info: SQLConnectionConfig, query: str, params: Optional[list] = None
):
import psycopg2

conn = psycopg2.connect(
Expand All @@ -29,17 +35,21 @@ def load_from_postgres(connection_info: SQLConnectionConfig, query: str):
dbname=connection_info.database,
port=connection_info.port,
)
return pd.read_sql(query, conn)
return pd.read_sql(query, conn, params=params)


def load_from_sqlite(connection_info: SqliteConnectionConfig, query: str):
def load_from_sqlite(
connection_info: SqliteConnectionConfig, query: str, params: Optional[list] = None
):
import sqlite3

conn = sqlite3.connect(connection_info.file_path)
return pd.read_sql(query, conn)
return pd.read_sql(query, conn, params=params)


def load_from_cockroachdb(connection_info: SQLConnectionConfig, query: str):
def load_from_cockroachdb(
connection_info: SQLConnectionConfig, query: str, params: Optional[list] = None
):
import psycopg2

conn = psycopg2.connect(
Expand All @@ -49,7 +59,7 @@ def load_from_cockroachdb(connection_info: SQLConnectionConfig, query: str):
dbname=connection_info.database,
port=connection_info.port,
)
return pd.read_sql(query, conn)
return pd.read_sql(query, conn, params=params)


__all__ = [
Expand Down
Loading

0 comments on commit 8f6db7b

Please sign in to comment.