Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

108 Do continuous benchmarks #647

Merged
merged 23 commits into from
Jun 16, 2021
Merged

108 Do continuous benchmarks #647

merged 23 commits into from
Jun 16, 2021

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented May 28, 2021

No description provided.

@kysrpex
* Benchmark class to control iterations and times.
db3707e 
* Some simple benchmarks for the CUDS API.
@kysrpex kysrpex added 📈 performance 💉 testing Solving the issue involves creating/modifying unit tests or benchmarks. labels May 28, 2021
@kysrpex kysrpex self-assigned this May 28, 2021
@kysrpex kysrpex linked an issue May 28, 2021 that may be closed by this pull request
Do continuous benchmarks #108
Closed
kysrpex and others added 11 commits June 1, 2021 09:04
@kysrpex
Rename benchmarks.py to benchmark.py.
37fb208
@kysrpex
* Add benchmarks for all the the methods of the CUDS API referenced i…
5bb570e 
…n the CUDS API tutorial.

* Add wrapper functions to make the benchmarks compatible with pytest-benchmark.

* Add `pytest.ini` file, needed for the benchmarks.
@kysrpex
Simplify pytest-benchmark wrapper functions using a template.
7760b14
@kysrpex
Simplify pytest-benchmark wrapper functions using a template (second …
8713b49 
…commit).
@kysrpex
Move pytest-benchmark wrapper functions template to the benchmark class.
ac515fb
@kysrpex
Fix missing function call.
d8d5aab
@kysrpex
Fix missing function call (again).
ff76484
@kysrpex
Change default size of CUDS API benchmarks to 500.
3f0f2cb
@kysrpex
Add benchmarks workflow.
97e83f5
@kysrpex
Update benchmark token name.
259db70
@kysrpex
Merge branch 'dev' into 108-Do_performance_tests
23f3acc
@kysrpex kysrpex marked this pull request as ready for review June 1, 2021 14:20
@kysrpex
Copy link
Contributor Author

kysrpex commented Jun 1, 2021 •
edited
Loading

Any idea on how to test the GitHub action without actually pushing to dev?

Edit: I'll try changing the branch of the action temporarily. -> Works

@kysrpex
Copy link
Contributor Author

kysrpex commented Jun 2, 2021

Say hi to our new benchmarks!

@kysrpex kysrpex marked this pull request as draft June 2, 2021 10:34
@kysrpex kysrpex marked this pull request as ready for review June 2, 2021 10:35
@kysrpex kysrpex merged commit 55ac8a2 into dev Jun 16, 2021
@kysrpex kysrpex deleted the 108-Do_performance_tests branch June 16, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavnash yoavnash yoavnash approved these changes

@pablo-de-andres pablo-de-andres Awaiting requested review from pablo-de-andres pablo-de-andres is a code owner

Assignees

@kysrpex kysrpex

Labels
📈 performance 💉 testing Solving the issue involves creating/modifying unit tests or benchmarks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do continuous benchmarks
2 participants
@kysrpex @yoavnash