Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python "3.13-dev" #2321

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Test against Python "3.13-dev" #2321

merged 2 commits into from
Aug 21, 2024

Conversation

simonw
Copy link
Owner

@simonw simonw commented Apr 14, 2024

@simonw
Copy link
Owner Author

simonw commented Apr 14, 2024

Confirmed an error with Pint:

/opt/hostedtoolcache/Python/3.13.0-alpha.6/x64/lib/python3.13/site-packages/pint/delegates/txt_defparser/common.py:21: in <module>
    @dataclass(frozen=True)
/opt/hostedtoolcache/Python/3.13.0-alpha.6/x64/lib/python3.13/dataclasses.py:1289: in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
/opt/hostedtoolcache/Python/3.13.0-alpha.6/x64/lib/python3.13/dataclasses.py:1044: in _process_class
    raise TypeError('cannot inherit frozen dataclass from a '
E   TypeError: cannot inherit frozen dataclass from a non-frozen one

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (39dfc7d) to head (26a4551).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2321   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          41       41           
  Lines        6401     6401           
=======================================
  Hits         5926     5926           
  Misses        475      475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw
Copy link
Owner Author

simonw commented Aug 21, 2024

It passed!

CleanShot 2024-08-20 at 19 14 23@2x

@simonw
Copy link
Owner Author

simonw commented Aug 21, 2024

The test failure was that intermittent unrelated failure we haven't solved yet.

@simonw simonw merged commit 4efcc29 into main Aug 21, 2024
40 of 41 checks passed
@simonw simonw deleted the python-3.13-dev branch August 21, 2024 02:15
@simonw simonw restored the python-3.13-dev branch August 21, 2024 02:15
@simonw simonw deleted the python-3.13-dev branch August 21, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant