Release Datasette 1.0a0

[simonw]

I attempted the release just now - https://github.com/simonw/datasette/releases/tag/1.0a0 - and got an unexpected test failure:

https://github.com/simonw/datasette/actions/runs/3577355358/attempts/1

>       assert delete_response.status_code == 200
E       assert 404 == 200
E        +  where 404 = <Response [404 Not Found]>.status_code

/home/runner/work/datasette/datasette/tests/test_api_write.py:396: AssertionError
=========================== short test summary info ============================
FAILED tests/test_api_write.py::test_delete_row[compound_pk_table-row_for_create2-pks2-article,k] - assert 404 == 200
 +  where 404 = <Response [404 Not Found]>.status_code

I hit "retry" on that test but I expect it to fail again.

[simonw]

Weird, retrying the tests DID get them to pass. https://github.com/simonw/datasette/actions/runs/3577355358/jobs/6016518244

[simonw]

... but the last step of the deploy failed, when it was meant to push to PyPI!

Uploading distributions to https://upload.pypi.org/legacy/
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.0/x64/bin/twine", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/__main__.py", line 33, in main
    error = cli.dispatch(sys.argv[1:])
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/cli.py", line 123, in dispatch
    return main(args.args)
           ^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 198, in main
    return upload(upload_settings, parsed_args.dists)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 123, in upload
    packages_to_upload = [
                         ^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 124, in <listcomp>
    _make_package(filename, signatures, upload_settings) for filename in uploads
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 77, in _make_package
    package = package_file.PackageFile.from_filename(filename, upload_settings.comment)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/package.py", line 96, in from_filename
    meta = DIST_TYPES[dtype](filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/wheel.py", line 42, in __init__
    self.extractMetadata()
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/pkginfo/distribution.py", line 121, in extractMetadata
    self.parse(data)
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/wheel.py", line 89, in parse
    fp = io.StringIO(distribution.must_decode(data))
                     ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkginfo.distribution' has no attribute 'must_decode'. Did you mean: '_must_decode'?
Error: Process completed with exit code 1.

[simonw]

datasette/.github/workflows/publish.yml

Lines 52 to 61 in 07aad51

	- name: Install dependencies
	run: |
	pip install setuptools wheel twine
	- name: Publish
	env:
	TWINE_USERNAME: __token__
	TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
	run: |
	python setup.py sdist bdist_wheel
	twine upload dist/*

[simonw]

https://pypi.org/project/setuptools/65.6.3/ came out most recently - 23rd November (wheel and twine are older).

No search results at all for that error message. This is very weird, I would have expected it to have been reported by now.

[simonw]

https://pypi.org/project/pkginfo/#history - 1.9.0 came out 39 minutes ago!

[simonw]

Filed a bug report here: https://bugs.launchpad.net/pkginfo/+bug/1998249

[simonw]

I deleted the tag and tried creating a new release. Now running here: https://github.com/simonw/datasette/actions/runs/3577554546

[simonw]

Looks like a fix is coming: pypa/twine#940 (comment)

Note that must_decode was defined in pkg_info/_compat.py, and was thus never an API: before 1.9.0, it was only imported and used in `pkginfo/distribution.py'.

Nevertheless, I will push out a 1.9.1 release of pkginfo which restores a deprecated compatibility alias.

[simonw]

Released:

• https://pypi.org/project/datasette/1.0a0/
• https://docs.datasette.io/en/latest/changelog.html#a0-2022-11-29