Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the spawned process exit after the output queue is empty #28

Merged
merged 5 commits into from
Feb 22, 2024

Wait until the queue is empty before the spawned process exits

7f4488a
Select commit
Loading
Failed to load commit list.
Merged

Let the spawned process exit after the output queue is empty #28

Wait until the queue is empty before the spawned process exits
7f4488a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 22, 2024 in 0s

85.89% (+0.03%) compared to 9519625

View this Pull Request on Codecov

85.89% (+0.03%) compared to 9519625

Details

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (9519625) 85.85% compared to head (7f4488a) 85.89%.

Files Patch % Lines
nextline/utils/queue.py 53.84% 5 Missing and 1 partial ⚠️
nextline/plugin/plugins/session/session.py 55.55% 3 Missing and 1 partial ⚠️
nextline/spawned/__init__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   85.85%   85.89%   +0.03%     
==========================================
  Files         113      115       +2     
  Lines        4306     4338      +32     
  Branches      710      715       +5     
==========================================
+ Hits         3697     3726      +29     
- Misses        546      548       +2     
- Partials       63       64       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.