Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update lint workflow action versions #21

Closed
wants to merge 1 commit into from

Conversation

MikeMcC399
Copy link

Issue

The GitHub Actions workflow .github/workflows/lint.yml is using outdated JavaScript actions.

Action Used Supported
actions/checkout v2 v4
actions/setup-node v1 v4

These actions attempt to run on node12 (end-of-life Apr 2022) and are forcefully migrated on the fly to use instead the supported node20 version.

Since there is no selection of a Node.js version in the use of actions/setup-node, it is installing Node.js v10.24.1 (end-of-life Apr 2021). This is in contrast to the default Node.js version of ubuntu-22.04 v18.20.5 or ubuntu-24.04 v20.18.1. The workflow uses ubuntu-latest which is currently in the process of migrating from ubuntu-22.04 to ubuntu-24.04.

Change

Update the action versions to the currently supported versions, and use Node.js Active LTS - at this time v22 - as most stable recommended version.

Action Supported Parameter
actions/checkout v4 N/A
actions/setup-node v4 node-version: 22

@MikeMcC399
Copy link
Author

Closing this PR as I subsequently realized:

  • the linting module xo (JavaScript/TypeScript linter (ESLint wrapper) with great defaults) is configured using xo@0.20.3. This causes the deprecation warning:

    npm warn deprecated eslint@4.19.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.

    ESLint Version Support shows that ESLint 4.x entered end-of-life on Dec 22, 2018.

  • attempting to update xo to newer versions, causes linting errors, including code which needs a higher min engines version, such as Node.js >=4.0.0 or >=7.6.0. Significant other coding changes would need to be made as well.

This PR could be readdressed after min engines is addressed and xo is updated.

@MikeMcC399 MikeMcC399 closed this Dec 10, 2024
@MikeMcC399 MikeMcC399 deleted the update/lint-ci branch December 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant