Prevent lineWidth object from filling the cell in black [#897] #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDabrowski
commented
Apr 17, 2023
17ef07c to
af34388
Compare
MikeDabrowski
commented
Apr 18, 2023
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely reworked the way the border drawing works. It now takes into consideration the neighbouring borders to achieve 'sharp' edge. Borders are still centered on cell edge.
If
lineWidth: numberis provided, borders will be drawn using rectangle with stroke.If
lineWidth: Partial<LineWidth>is provided, borders will be drawn individually.The tests passed, and from what I could see, all examples are working. I've also added example page with borders showcase - it may not be beautiful but showcases what can be done with the borders now.
Closes #897