Add support for lineHeightFactor

[mmghv]

Fixes #767, #712, #753, #887, #802, #906

Reference PR : #754

Before

After

Example code

const doc = new jsPDF();

table(10, 'LineHeightFactor: 1.15 \n(default)')

doc.setLineHeightFactor(0.9)
table(80, 'LineHeightFactor: 0.9')

doc.setLineHeightFactor(2.5)
table(150, 'LineHeightFactor: 2.5')

function table(x, title) {
  doc.text(title, x, 40)

  doc.autoTable({
    body: [
      ['text\non\nfour\nlines'],
      ['text on one line'],
      ['text on one line'],
    ],
    theme: 'grid',
    tableWidth: 50,
    startY: 50,
    styles: {
      textColor: 'black',
      fontSize: 18,
      lineColor: 0,
      // cellPadding: 0,
    },
    margin: {left: x}
  })
}

[simonbengtsson]

Awesome! I guess this is technically a breaking change, but should we release it ahead of v4 anyway since it's such a nice addition? Or maybe simple release v4 as a minor update with bigger changes in V5?

[mmghv]

I don't think this is a breaking change, it was a bug, if you changed lineHeightFactor from the default, you get unexpected results (broken text in multiline cells) like shown in the image and reported in the issues.

So IMHO this should be merged in v3, I have no problem with it though if you want it to be deferred to v4.

[simonbengtsson]

Aha got it. I thought it was adding support for line height factor in jspdf but see what you mean now.

[mmghv]

I thought it was adding support for line height factor

It is adding support for lineHeightFactor from jspdf instead of using the hard-coded 1.15 value, so the line height could be changed with doc.setLineHeightFactor() jspdf method.

It was done before in this PR #754 but was not completed.