Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for encryption on the web #274

Merged
merged 10 commits into from
Jan 10, 2025
Merged

Initial support for encryption on the web #274

merged 10 commits into from
Jan 10, 2025

Conversation

simolus3
Copy link
Owner

@simolus3 simolus3 commented Jan 6, 2025

Add support for using sqlite3mc with web builds. This appears to be working, but there are some remaining issues to address:

  • This replaces the build scripts to only compile sqlite3mc. We should compile both upstream sqlite3 and with sqlite3mc.
  • Due to the way we set up virtual file systems (after loading sqlite3, not in sqlite3_os_init), we need to disable SQLITE_AUTOINIT with sqlite3mc because that extension sets up an extrainit to turn the default vfs into an encrypted vfs. That fails, as there is no default VFS at that point. The current setup is backwards-compatible (since old wasm bundles have autoinit and we can start calling sqlite3_initialize in new versions). Still, I prefer to keep AUTOINIT enabled for the default build.
  • This also needs more tests.

@simolus3 simolus3 marked this pull request as ready for review January 10, 2025 23:52
@simolus3 simolus3 merged commit 7fb61e4 into main Jan 10, 2025
28 checks passed
@simolus3 simolus3 deleted the web-encryption branch January 10, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant