Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lazy object and array iterators, closes and #406 #407

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

Licenser
Copy link
Member

No description provided.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.77%. Comparing base (8a9169b) to head (5ee4d3e).
Report is 200 commits behind head on main.

Files with missing lines Patch % Lines
src/value/lazy/array.rs 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8a9169b) and HEAD (5ee4d3e). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (8a9169b) HEAD (5ee4d3e)
128bit 2 0
3 0
beef 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #407       +/-   ##
===========================================
- Coverage   81.83%   66.77%   -15.06%     
===========================================
  Files          32       50       +18     
  Lines        9992    12284     +2292     
===========================================
+ Hits         8177     8203       +26     
- Misses       1815     4081     +2266     
Flag Coverage Δ
?
128bit ?
beef ?
unittests 66.77% <78.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link

Benchmark for 253a219

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.1±1.51µs 92.1±1.88µs +1.10%
canada/simd_json::to_tape_with_buffers 3.3±0.14ms 3.4±0.18ms +3.03%
citm_catalog/simd_json::to_tape_with_buffers 1128.4±91.59µs 1131.5±81.00µs +0.27%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.23µs 3.9±0.27µs +5.41%
github_events/simd_json::to_tape_with_buffers 40.2±0.97µs 40.9±1.00µs +1.74%
log/simd_json::to_tape_with_buffers 1551.9±87.15ns 1546.4±83.51ns -0.35%
twitter/simd_json::to_tape_with_buffers 441.4±31.71µs 442.7±26.76µs +0.29%

Copy link

Benchmark for e01a4b6

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.3±2.53µs 90.9±1.50µs -0.44%
canada/simd_json::to_tape_with_buffers 3.3±0.12ms 3.3±0.16ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1125.1±80.16µs 1119.7±74.95µs -0.48%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.22µs 3.7±0.23µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.1±0.96µs 40.1±1.00µs 0.00%
log/simd_json::to_tape_with_buffers 1573.8±89.68ns 1575.9±85.75ns +0.13%
twitter/simd_json::to_tape_with_buffers 439.7±25.24µs 439.7±23.70µs 0.00%

@Licenser Licenser enabled auto-merge (rebase) November 17, 2024 15:22
@Licenser Licenser merged commit 7db17c4 into main Nov 17, 2024
23 checks passed
@Licenser Licenser deleted the publish-lazy-iterators branch November 17, 2024 15:27
Copy link

Benchmark for 0e7c58d

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.3±1.81µs 91.9±2.84µs +0.66%
canada/simd_json::to_tape_with_buffers 3.4±0.14ms 3.5±0.15ms +2.94%
citm_catalog/simd_json::to_tape_with_buffers 1126.3±71.97µs 1136.3±71.80µs +0.89%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.26µs 3.7±0.24µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.5±1.31µs 40.3±1.09µs -0.49%
log/simd_json::to_tape_with_buffers 1538.5±76.78ns 1531.1±72.66ns -0.48%
twitter/simd_json::to_tape_with_buffers 438.3±26.03µs 444.3±27.08µs +1.37%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant