Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netCDF extension nc #4

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add netCDF extension nc #4

merged 2 commits into from
Jul 20, 2022

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jul 20, 2022

@axelboc axelboc requested a review from loichuder July 20, 2022 12:34
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the plethora of HDF5 extensions out there, this is bound to happen again.

Would there be a way to have something similar than for the h5wasm demo ? Extensions encouraged but not enforced ?

If not, we should add something in the README to indicate which extensions are supported (and why) and how a simple renaming can bypass this.

@axelboc
Copy link
Contributor Author

axelboc commented Jul 20, 2022

Yep... Unfortunately, the custom editor contribution point only allows providing an array of glob patterns: https://code.visualstudio.com/api/references/contribution-points#contributes.customEditors

Good point on adding the list to the readme.

@axelboc axelboc requested a review from loichuder July 20, 2022 13:29
@axelboc
Copy link
Contributor Author

axelboc commented Jul 20, 2022

I didn't explicitly suggest renaming files, as I think explaining that it relies on filename extensions is clear enough.

@axelboc axelboc merged commit 080045e into main Jul 20, 2022
@axelboc axelboc deleted the add-ext branch July 20, 2022 13:49
@fangrh fangrh mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants