Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Blosc2 HDF5 filter #201

Merged
merged 16 commits into from
Dec 14, 2022
Merged

Adding Blosc2 HDF5 filter #201

merged 16 commits into from
Dec 14, 2022

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Nov 9, 2022 •
edited
Loading

Very early integration of blosc-2 HDF5 compression filter in hdf5plugin.
There is still some work to do regarding compilation options, enabling SIMD, using zlib-ng, and testing.

Form what I tested, there is an issue with zlib. (fixed)

related to #194

@t20100 t20100 mentioned this pull request Nov 23, 2022
Merged
@FrancescAlted
Copy link

Sounds good. I've added a couple of notes about your experience with the optimal number of threads.

@t20100 t20100 force-pushed the blosc2 branch 2 times, most recently from ff183ba to 7282cc5 Compare November 30, 2022 10:24
@t20100
Copy link
Member Author

t20100 commented Dec 9, 2022

There is an issue with universal2 build on macos (see https://gitlab.esrf.fr/silx/bob/hdf5plugin/-/jobs/512995).
I'll look more at it next week

attn @FrancescAlted

This was referenced Dec 14, 2022
Closed
Open
@t20100
Copy link
Member Author

t20100 commented Dec 14, 2022 •
edited
Loading

Fixed issue with zlib (5264e11) and added P9 altivec SIMD support (1f9a9e8).

Still need to fix universal2 build.

Remaining improvements that I would prefer to do in other PRs:

@t20100 t20100 mentioned this pull request Dec 14, 2022
Closed
@t20100
Copy link
Member Author

t20100 commented Dec 14, 2022

Related c-blosc2 issue: Blosc/c-blosc2#430

@t20100 t20100 mentioned this pull request Dec 14, 2022
Merged
@t20100
Copy link
Member Author

t20100 commented Dec 14, 2022

This PR Blosc/c-blosc2#431 proposes a fix to c-blosc2 regarding universal2 build on macos and it is included in this PR (commit 97b7b38).

To me, this can be reviewed and merged to move forward, but I'd wait for the issue to be fixed upstream before making a release of hdf5plugin.

Anyway, ready for review.

@t20100 t20100 marked this pull request as ready for review December 14, 2022 13:33
@t20100
Copy link
Member Author

t20100 commented Dec 14, 2022

PR Blosc/c-blosc2#431 has been merged.
So to me, this PR can be merged (and eventually released).

@t20100 t20100 requested a review from vasole December 14, 2022 18:04
@t20100 t20100 added this to the Next release milestone Dec 14, 2022
vasole
vasole approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@vasole vasole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasole vasole merged commit 1d93b5b into silx-kit:main Dec 14, 2022
@vasole vasole mentioned this pull request Dec 16, 2022
Closed
@t20100 t20100 deleted the blosc2 branch December 16, 2022 15:39
@t20100 t20100 mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescAlted FrancescAlted FrancescAlted left review comments

@vasole vasole vasole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t20100 @FrancescAlted @vasole