Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split PanZoom mesh in Pan and Zoom meshes #953

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Split PanZoom mesh in Pan and Zoom meshes #953

merged 1 commit into from
Feb 7, 2022

Conversation

loichuder
Copy link
Member

Also refactored the viewport centering on resize: it was extracted from the interaction meshes into a dedicated component ViewportCenter.

@loichuder loichuder requested a review from axelboc February 7, 2022 10:48
axelboc
axelboc approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this opens up a lot of possibilities.

packages/lib/src/vis/shared/PanMesh.tsx Show resolved Hide resolved
packages/lib/src/vis/shared/ViewportCenterer.tsx Show resolved Hide resolved
packages/lib/src/vis/shared/ViewportCenterer.tsx Outdated Show resolved Hide resolved
packages/lib/src/vis/shared/ZoomMesh.tsx Show resolved Hide resolved
packages/lib/src/vis/shared/ViewportCenterer.tsx Show resolved Hide resolved
@loichuder loichuder force-pushed the pan-zoom-components branch from a1f7fd5 to a03d289 Compare February 7, 2022 13:20
@loichuder loichuder merged commit c5b9d24 into main Feb 7, 2022
@loichuder loichuder deleted the pan-zoom-components branch February 7, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loichuder @axelboc