Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let MappedHeatmapVis and related utilities accept typed arrays #950

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Let MappedHeatmapVis and related utilities accept typed arrays #950

merged 1 commit into from
Feb 4, 2022

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Feb 4, 2022

This has already impacted quite a few files, so I thought I'd keep further changes (line vis, providers, etc.) for separate PRs.

axelboc
axelboc commented Feb 4, 2022
View reviewed changes
apps/storybook/src/Utilities.stories.mdx Show resolved Hide resolved
packages/app/src/vis-packs/core/heatmap/MappedHeatmapVis.tsx Show resolved Hide resolved
packages/app/src/vis-packs/core/hooks.ts Show resolved Hide resolved
packages/app/src/vis-packs/core/hooks.ts Show resolved Hide resolved
packages/lib/src/vis/utils.ts Show resolved Hide resolved
packages/shared/src/guards.ts Show resolved Hide resolved
packages/shared/src/models-vis.ts Show resolved Hide resolved
packages/shared/src/utils.ts Show resolved Hide resolved
@axelboc axelboc requested a review from loichuder February 4, 2022 11:53
loichuder
loichuder approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
packages/app/src/vis-packs/core/heatmap/MappedHeatmapVis.tsx Show resolved Hide resolved
@axelboc axelboc merged commit 92f68f5 into main Feb 4, 2022
@axelboc axelboc deleted the mapped-ndarray branch February 4, 2022 14:28
@loichuder loichuder mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder