Flip only the needed meshes rather than the whole canvas #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in essence a revert of #813
While this seemed very elegant for texture-based meshes, this introduces an issue for meshes that make use of the axis scales to position themselves (through
dataToWorld).Indeed, the
flipis already accounted for in the scales (which make sense for axes) so that coordinates computed through them already have the correct flipped coordinates. As a consequence, having an inverting group around such meshes flip them once more which is incorrect.Examples of such meshes include
SelectionMeshor the ones used inLineVis.