Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to artifact URL from PR when visual diffing fails #1547

Closed
wants to merge 2 commits into from

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jan 15, 2024

The upload-artifact action finally exposes an artifact-url output! This was probably their most requested features.

This means we can provide a link to download the artifacts from the PR when visual diffing fails. I do this using the create-or-update-comment action.

@axelboc
Copy link
Contributor Author

axelboc commented Jan 15, 2024

Arf, I can't get this to work because of the fact that we skip pull_request events on local PRs. So I have access to the artifact-url only in jobs triggered by the push event, which don't give easy access to the PR number (since it may not exist yet). Closing for now; might revisit this at a later date.

@axelboc axelboc closed this Jan 15, 2024
@axelboc axelboc deleted the artifact-url branch January 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant