Add JSON export to Raw visualization #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Sep 1, 2023
This was referenced Sep 1, 2023
t20100
approved these changes
Sep 4, 2023
loichuder
reviewed
Sep 11, 2023
| @@ -8,23 +10,13 @@ function RawVis(props: Props) { | |||
| const { value } = props; | |||
| const valueAsStr = JSON.stringify(value, null, 2); | |||
There was a problem hiding this comment.
This step could be time consuming if value is too big. I wonder if we could infer the size in another lighter way.
There was a problem hiding this comment.
Yeah, I did wonder about that. On the other hand, the value first has to be downloaded, which takes a lot more time than JSON.stringify. Even in VS Code we have a 2GB limit on the size of the HDF5 file, so I'm not hugely concerned. Given that the raw vis is for datasets that have complicated dtypes, I'm not sure there's an easier way to approximate the size... So I'd prefer to wait for someone to hit this potential bottleneck before trying to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Rawvisualization now supports exporting datasets to JSON when using the h5grove, h5wasm and mock providers.This provides a much better solution to issue #917 than PR #1462 . As such, large raw datasets that can't be rendered on the screen are no longer logged to the console.
Concerning large datasets, I took the opportunity to do some more testing and decided to increase the threshold for when a dataset is considered to be large by a few orders of magnitude. This is purely empirical...