Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SVG overlay and floating toolbar out of r3fRoot #1471

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Aug 11, 2023

#1467 allows further simplification:

  • svgOverlay can be rendered directly into canvasWrapper instead of r3fRoot. This opens up an opportunity to let SVG elements overflow in the future; however, for now, the overflow remains hidden. It also removes the need to render the overlay with Html, which most likely provides a very small performance gain on initial render.
  • floatingToolbar can be rendered into visCanvas and positioned with CSS Grid properties. This paves the way to Event propagation to canvas #1388 (comment) and also removes the need for Html.

@axelboc axelboc requested a review from loichuder August 11, 2023 08:44
@axelboc
Copy link
Contributor Author

axelboc commented Aug 11, 2023

/approve

Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

Base automatically changed from fix-annoations to main August 21, 2023 13:33
@axelboc axelboc merged commit 7bfbe65 into main Aug 21, 2023
@axelboc axelboc deleted the out-of-r3froot branch August 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants