Move SVG overlay and floating toolbar out of r3fRoot
#1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1467 allows further simplification:
svgOverlay
can be rendered directly intocanvasWrapper
instead ofr3fRoot
. This opens up an opportunity to let SVG elements overflow in the future; however, for now, the overflow remains hidden. It also removes the need to render the overlay withHtml
, which most likely provides a very small performance gain on initial render.floatingToolbar
can be rendered intovisCanvas
and positioned with CSS Grid properties. This paves the way to Event propagation to canvas #1388 (comment) and also removes the need forHtml
.