Enforce stricter scale types #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4c9a45 to
62f1f16
Compare
axelboc
commented
May 2, 2023
packages/app/src/vis-packs/nexus/containers/NxComplexSpectrumContainer.tsx
Show resolved
Hide resolved
axelboc
commented
May 2, 2023
loichuder
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple components accepting scale types as props (either directly or via an object prop), as well as utility functions and hooks, were wrongly allowed to receive:
ScaleType.Gammawithout a corresponding exponentScaleType.SqrtandScaleType.Gammaeven when those scale types were not meant to be supportedThe first issue was due to type
VisScaleTypeincorrectly usingOmitinstead ofExcludeto deal with the special case ofScaleType.Gamma. The second issue was due to props and parameters being typed withScaleTypewithout consideration for unsupported scales.I've done a few more refactorings along the way in separate commits, like renaming the confusing
AxisScaleandcreateAxisScaleto justScaleandcreateScale, and splitting theH5WEB_SCALESrecord, which was dealing with totally unrelated responsibilities.