Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacking of domain slider tooltip #1235

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix stacking of domain slider tooltip #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lib/src/toolbar/Toolbar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.toolbar {
flex: 1 1 0%;
position: relative; /* for `z-index` below, in case parent doesn't have `display: flex`*/
position: relative; /* for `z-index` below, in case parent doesn't have `display: flex` */
z-index: 1; /* for toolbar menus to appear above visualizations (overflow, selectors) */
display: flex;
min-width: 0;
Expand Down
7 changes: 5 additions & 2 deletions packages/lib/src/toolbar/controls/DomainSlider/DomainTooltip.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
.tooltip {
composes: popup from '../../Toolbar.module.css';
left: 50%;
/* FIX style ordering issue with Vite */
transform: translate(-50%, 100%) !important;
z-index: 2; /* above overflow and selector menus */
transform: translate(
-50%,
100%
) !important; /* FIX style ordering issue with Vite */
/* Add invisible padding around tooltip to extend hover area */
/* (especially for when enabling auto-scaling hides an error message). */
padding-left: 2rem;
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/toolbar/controls/Selector/Selector.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
top: calc(100% + 0.75rem);
left: 50%;
transform: translateX(-50%); /* center menu with button */
z-index: 1; /* above other selectors */
z-index: 1; /* above overflow menu */
min-width: 100%;
padding-top: 0.25rem;
background-color: var(--h5w-selector-menu--bgColor, white);
Expand Down