Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacking context of floating toolbar #1184

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

loichuder
Copy link
Member

Before After
image image

@loichuder loichuder requested a review from axelboc August 8, 2022 13:51
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to create a stacking context, perhaps on canvasWrapper so the z-index of the floating toolbar does not "leak" to the document's stacking context.

You can replicate this (potential) issue by giving a higher z-index value to the floating toolbar, opening the overflow menu of the main toolbar, and resizing the window so the overflow menu appears under the reset-zoom button.

By setting z-index: 0 on .canvasWrapper (and thus creating a new stacking context, since it already has position: relative), the risk of a future stacking problem disappears.

@loichuder loichuder force-pushed the fix-stacking-floating branch from 99795fb to 4a10b6d Compare August 9, 2022 06:49
@loichuder loichuder force-pushed the fix-stacking-floating branch from 4a10b6d to edac01d Compare August 9, 2022 06:50
@loichuder loichuder merged commit bff598c into main Aug 9, 2022
@loichuder loichuder deleted the fix-stacking-floating branch August 9, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants