Warn when trying to register two interactions with the same ID #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we throw instead? 🤔 One one hand, this is a developer error, so it would make sense to throw so the problem gets caught during development. Not every app has feature tests that crash when warnings are logged... On the other hand, I can imagine situations where multiple interaction components with the same ID are rendered at the same time in production due to an unlikely combination of states that was missed during development... Crashing the entire vis because of that would not be fun for users. |
loichuder
approved these changes
Jul 1, 2022
47efcdf to
62d78b7
Compare
d3190a8 to
669bc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when this occurs, the second interaction no longer replaces the first. See #1143 (comment)