Let Pan accept multiple mouse buttons #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29671af to
e2a1b53
Compare
axelboc
commented
Jun 30, 2022
loichuder
approved these changes
Jul 1, 2022
3d56359 to
0b5ad5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1143
With the above, panning is allowed with either the left or the middle button. Obviously, contrary to the
modifierKeyprop, the logic here is "OR", not "AND".I've documented the new behaviour in the Storybook and took the opportunity to add a story to demonstrate setting multiple modifier keys.