Move mandlebrot to web worker in tiled heatmap story #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
May 25, 2022
|
|
||
| const array = ndarray(new Float32Array(height * width), [height, width]); | ||
| const array = new Float32Array(height * width); |
There was a problem hiding this comment.
I can't use ndarray inside the worker because of the way greenlet works. It's limited to functions that don't rely at all on external scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a library called greenlet, which works beautifully. It creates an inline worker with the function you give it: https://github.com/developit/greenlet and wraps it in a promise API. It's super tiny too.
The demo is a lot more fluid, though still not amazing on my machine, as we're still doing all the computations on the CPU. It can't compare exactly to a fetch-based scenario, but it's already a lot better.