Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add util getAxisValues in h5web/lib #1123

Merged
merged 1 commit into from
May 24, 2022
Merged

Add util getAxisValues in h5web/lib #1123

merged 1 commit into from
May 24, 2022

Conversation

loichuder
Copy link
Member

Fix #1073

@loichuder loichuder requested a review from axelboc May 23, 2022 15:01
axelboc
axelboc approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just need to add the new util/hook to the Utilities doc page.

@axelboc
Copy link
Contributor

axelboc commented May 24, 2022

Great choice of name for getPixelEdgeValues 💯

@loichuder loichuder requested a review from axelboc May 24, 2022 12:37
axelboc
axelboc approved these changes May 24, 2022
View reviewed changes
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
apps/storybook/src/Utilities.stories.mdx Outdated Show resolved Hide resolved
@loichuder loichuder merged commit 3f2d60e into main May 24, 2022
@loichuder loichuder deleted the get-axis-values branch May 24, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getAxisValues-like utility for line vis
2 participants
@loichuder @axelboc