Add support for complex dataset values in h5wasm #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
May 11, 2022
| export function convertMetadataToDType(metadata: NumericMetadata): NumericType; | ||
| export function convertMetadataToDType(metadata: Metadata): DType; | ||
| export function convertMetadataToDType(metadata: Metadata): DType { | ||
| if (isIntegerMetadata(metadata)) { |
There was a problem hiding this comment.
I reworked the switch to use dedicated guards to allow TS to infer the typing of metadata.
It allows more specific destructurings for Integer, Float and String but the important part is that compound metadata is correctly inferred.
| if (nmembers === 2 && members[0].name === 'r' && members[1].name === 'i') { | ||
| const [realTypeMetadata, imagTypeMetadata] = members; | ||
| assertNumericMetadata(realTypeMetadata); | ||
| assertNumericMetadata(imagTypeMetadata); |
There was a problem hiding this comment.
Thanks to this assertion and the overload of convertMetadataToDType above, TS knows that converting this will yield a NumericType removing the need to assert after conversion.
| class: DTypeClass.Compound, | ||
| fields: Object.fromEntries( | ||
| members.map((member) => [member.name, convertMetadataToDType(member)]) | ||
| ), |
There was a problem hiding this comment.
Following our line of work in HSDS, we try to be as specific as possible even if it is not complex and that we don't provide visualizations for such types.
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to v0.4.2 of h5wasm
I still have some issues with boolean which is why it is not included in this PR