Include link metadata for h5wasm and fix unresolved entities #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
May 6, 2022
| kind: EntityKind.Unresolved, | ||
| } as UnresolvedEntity; | ||
| }; |
There was a problem hiding this comment.
attributes were undefined for "other" entities.
It was not caught by TS due to the type assertion as UnresolvedEntity that allows missing/additionnal field in an object.
To avoid such issues in the future, we should perhaps use type declaration rather than type assertion. See this simple example
There was a problem hiding this comment.
Good point, the extra variable is annoying, but if it detects this sort of errors, it is indeed worth it.
axelboc
approved these changes
May 9, 2022
| kind: EntityKind.Unresolved, | ||
| } as UnresolvedEntity; | ||
| }; |
There was a problem hiding this comment.
Good point, the extra variable is annoying, but if it detects this sort of errors, it is indeed worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1100
I also fixed an issue with
Unresolvedentities (such as datatypes): clicking on theInspectpage would showattributes are undefined.