Show auxiliary plot colors in line vis tooltip #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #970
The tooltip remains unchanged when no auxiliaries are passed (i.e. the color of the main plot is not shown unless there are auxiliary plots).
The tooltip code of the line vis is starting to take quite a bit of space, but I wasn't sure if it was worth extracting the whole thing into a separate component, since we need access to so many props/variables from
LineVis. Perhaps there's a way to abstract things but I'm not seeing it yet, especially since everything in there is so specific to the line vis at the moment.