Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring support for axis scale type in ScatterVis #1047

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Conversation

loichuder
Copy link
Member

With the refactoring suggested in #1040 (review)

@loichuder loichuder requested a review from axelboc April 1, 2022 08:28
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, this really makes the ScatterVis more consistent with the other vis.

@loichuder
Copy link
Member Author

/approve

@loichuder loichuder merged commit 82fba77 into main Apr 1, 2022
@loichuder loichuder deleted the scatter-axes branch April 1, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants