Handle interaction key conflicts by setting them in VisCanvas #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
Mar 17, 2022
d9331bd to
dff4ccb
Compare
axelboc
approved these changes
Mar 21, 2022
5c449aa to
a60c6f4
Compare
axelboc
approved these changes
Mar 21, 2022
a60c6f4 to
e00005c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepping stone for #1013
Following our discussion, here is a first prototype to have interaction configuration stored at a single place (here
AxisSystemContext) to have a place where we can handle interactions between interactions (do you follow?).Also, this allows to have a more permissive behaviour for interactions with a
modifierKeyset toundefined(Panin particular). They will now only be prevented if the pressed modifier key is bound to another interaction.This fixes #1015 as default modifier keys values in these components were removed, allowing modifier keys to be set to
undefined.