Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put interaction components and utils in a dedicated folder #1019

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Put interaction components and utils in a dedicated folder #1019

merged 1 commit into from
Mar 17, 2022

Conversation

loichuder
Copy link
Member

@loichuder loichuder commented Mar 15, 2022 •
edited
Loading

I hesitate to include Tooltip and ViewportCenterer as well 🤷

@loichuder loichuder force-pushed the interaction-folder branch from 14b78ba to 91ad388 Compare March 15, 2022 16:11
@loichuder loichuder requested a review from axelboc March 15, 2022 16:13
axelboc
axelboc approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@axelboc
Copy link
Contributor

axelboc commented Mar 16, 2022 •
edited
Loading

Hmm, definitely not ViewportCenterer and I think we can leave Tooltip where it is as well. I reckon we can use the help popup as reference for what is considered an interaction.

@loichuder loichuder merged commit 5493f69 into main Mar 17, 2022
@loichuder loichuder deleted the interaction-folder branch March 17, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loichuder @axelboc