-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default line colors for better contrast and distinction of auxiliary plots #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me likes it ✨
I've managed to implement dark mode support for the line vis colors. I use If the user doesn't specify colors, I pass my own defaults (either one value used for both light and dark, or two separate values) to Of course, I've then reviewed all the default colors so that they are now consistent and contrasting in both light and dark mode: |
/approve |
Update Cypress reference snapshots
Part of silx-kit/jupyterlab-h5web#82
The
--secondary-dark
color gets a bit lost if I try to give auxiliary plots more distinct colours. Changing to the default colour for the main plot,midnightblue
, makes it pop out more, which means I can also use the default aux colours:orangered, forestgreen, crimson, mediumslateblue, sienna
.We've had that green for a long time, so it's going to take some getting used to, but it's not shocking. It's also closer to Matplotlib I think (that's where we got the default colours from, if I recall).