forked from tiann/KernelSU
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
**Changes** 1. With the addition of the Action button the module card feels pretty bloated when all of them are present at the same time.  To improve it we can use icons only instead of text since they take less space; this also means adding an icon for Update and Uninstall buttons.  Below are displayed other possible behaviors when not all of them are present:    Since the Update button appears less frequently than the others, make it always display its text unless both Action and WebUI are present.  2. Minor change to avoid possible missclicks caused by smaller buttons. Enabling and disabling modules is pretty rare by itself and considering overlayfs isn't as fast as magic mount a missclick often feels pretty punishing. 3. The commit 7b3e732 readded transitions to all sections but I noticed they were missing from Home. With the help of @rifsxd I found out it was cause of the lag generated by the install function, which is called everytime you go to Home. Since installing magiskboot multiple times isn't needed, moving it to MainActivity ensures it's executed on app launch only avoiding unnecessary lag. Tested-by: backslashxx 118538522+backslashxx@users.noreply.github.com --------- Co-authored-by: changhuapeng <9205678+changhuapeng@users.noreply.github.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com>
- Loading branch information
1 parent
83d7db0
commit 29e2b9f
Showing
3 changed files
with
54 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters