Merge pull request #108 from creative-commoners/pulls/4/protect-hooks

API Set extension hook implementation visibility to protected
silverstripe · May 21, 2024 · 663e34e · 663e34e
2 parents de10b46 + c61d9ff
commit 663e34e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/VersionFeed.php b/src/VersionFeed.php
@@ -28,7 +28,7 @@ class VersionFeed extends SiteTreeExtension
         'PublicHistory' => true
     );
 
-    public function updateFieldLabels(&$labels)
+    protected function updateFieldLabels(&$labels)
     {
         $labels['PublicHistory'] = _t(__CLASS__ . '.LABEL', 'Make history public');
     }
@@ -171,7 +171,7 @@ public function getDiff()
         return null;
     }
 
-    public function updateSettingsFields(FieldList $fields)
+    protected function updateSettingsFields(FieldList $fields)
     {
         if (!$this->owner->config()->get('changes_enabled')) {
             return;

diff --git a/src/VersionFeedController.php b/src/VersionFeedController.php
@@ -60,7 +60,7 @@ protected function filterContent($key, $callback)
         }
     }
 
-    public function onAfterInit()
+    protected function onAfterInit()
     {
         $this->linkToPageRSSFeed();
         $this->linkToAllSiteRSSFeed();

diff --git a/src/VersionFeedSiteConfig.php b/src/VersionFeedSiteConfig.php
@@ -24,12 +24,12 @@ class VersionFeedSiteConfig extends DataExtension
         'AllChangesEnabled' => true
     );
 
-    public function updateFieldLabels(&$labels)
+    protected function updateFieldLabels(&$labels)
     {
         $labels['AllChangesEnabled'] = _t(__CLASS__ . '.ALLCHANGESLABEL', 'Make global changes feed public');
     }
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         if (!Config::inst()->get(VersionFeed::class, 'allchanges_enabled')) {
             return;