-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Silverstripe 5 #80
Conversation
80c306e
to
33f3a6b
Compare
653601a
to
655c155
Compare
51e9c10
to
b2039ec
Compare
@madmatt keen to get your thoughts on this. I still need to run through manual testing, but I think all major changes have now been made. In particular, I really don't know anything about how Algolia configuration would work, and I think this module is (currently) quite opinionated in how it expects you to provide your index configuration. CC: @GuySartorelli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done a proper review as I don't have a way to run elastic atm but this looks like a great step in the right direction.
Once this gets merged it should probably have a beta release at first, to leave room for any breaking changes needed to let this work with services (e.g. algolia) other than elastic.
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Nice one, thanks @chrispenny! Overall it looks good, I agree with you about how index configuration is managed, perhaps I can work through that as part of the Algolia change when I get to it. |
Manual testing completed in silverstripe/silverstripe-search-service-elastic#1. I'm about as happy as I'm going to get, considering I won't be able to test this on a real project for quite some time. I'll look to merge this soon, and I'll tag this as a beta. Thanks for all the help, team :D |
RFC: Extract Elastic-specific classes into a separate module #81
This PR includes the removal of the Elastic integration, and this is now going to be provided by Silverstripe Search Service - Elastic module.
Breaking changes
8.1
linting/declaration updates. If you have extended any of our classes, there might be some signature updates that you need to make.EnterpriseSearchService::environmentizeIndex()
is no longer static, and this is now part of the contract forIndexingInterface
. If you were referencing or overriding this method, then you might need to update your implementation.Silverstripe 5 support
There actually wasn't much that needed to change. The default property value in DataObjectFetcher was the most significant change.