Index configuration overrides DO subsite field if NULL value

[mark-a-j-adriano]

Background:

DataObject does not have a SubsiteID field and is not being indexed even if explicitly defined in the Subsite Config.

Added Solution:

• Allow indexing of DO even if SubsiteID is not defined (null)
• Allow DO to be added on multiple Subsite search Index

App\Model\Product: &product_defaults
          fields:
            title:
              property: Title
            last_updated:
              property: LastUpdated
            code:
              property: Code
              options:
                type: text

[andrewandante]

Some minor tidy ups but the idea makes sense - I'd like some sort of documentation around this as well, so if there's space in the ReadMe to add a line that says something like:

"If you are using subsites, but your object doesn't have a subsite ID, it will be included inthe index if it is explicitly added, e.g. "

Then that would be awesome

[mark-a-j-adriano]

Admin change works fine on local.

[andrewandante]

Hi @mark-a-j-adriano - with the PHP8 upgrade this PR has gone quite stale I'm afraid 😣 do you want to take another swing at it, or rather convert it to an issue for someone else to tackle?

[mark-a-j-adriano]

@andrewandante -> Looks like @satrun was able to add the test fix. Kindly check this again. @satrun Thanks for the assist.

[andrewandante]

Hi team! If you need this for PHP7.X then you'll need to point it at the 1 branch, and if you want it to be for the PHP8.X branch (2) then please remove the travis.yml as testing has moved to Github actions :)

[satrun77]

Fix for version 2 and PHP8 only. I will remove travis :)

[satrun77]

I see that 🙂I will fix GitHub actions

[andrewandante]

Some failures here - I think there is some linting to do, and also the subsites module needs to be included via composer perhaps?

[andrewandante]

Won't this mean that if it's in the second index, but not the first, it won't be indexed appropriately?

[satrun77]

I will test this scenario and update PR.

[andrewandante]

Code looks good to me, thanks for persisting! Please squash up your commits and then I'd be happy to merge 😄