Rephrase error messages

[NightJar]

Currently "File does not match MIME type" doesn't mean much to the average user. It's a tricky one to phrase because "file extensions" aren't generally a well known concept either.

Also unsure at this point is whether this is simply translation based, but in any case we can update the default string for a translation, which is in the code.

[robbieaverill]

@NightJar can you triage this for the version affecting you? I assume it's probably both SS3 and SS4

[NightJar]

Hmm, I haven't done my due dilligence with this issue (didn't link related). I think it was related to silverstripe/silverstripe-asset-admin#708 which has since been solved, so should probably be checked to see if this is still a thing. In any case I believe it'll be a 4 only thing due to the changes in asset management with the major version release.

In any case renaming the default translation string shouldn't be too difficult, I think this was opened so I could get e.g. @clarkepaul or @sachajudd to weigh in, with that respect (and also as a reminder to check on the above).

[NightJar]

Cool, so the customised error message now displays, thanks to UncleCheese's fix.
But the UX portion of this issue with regards to the error message itself is still in need of addressing. Attached is a screenshot as requested by @sachajudd :)

[clarkepaul]

"Unknown file type (MIME)" would make more sense but why is a PNG not being allowed here?

[NightJar]

I think this is more in reference to the general concept of a MIME type not being something the average user is aware of. Such as you providing a perfect example in your comment @clarkepaul (not sure if that's intentional or not) - the PNG isn't a png. It's a text file (see second window in screenshot, just below the upload field).

Something like "File doesn't appear to be what it says it is" (although clearly that's also a bit rubbish) might be better.

[clarkepaul]

"File extension and type is not supported or recognised"?

[NightJar]

"File type does not match extension ($EXT)"
e.g. (using the same example) File type does not match extension (.PNG)?

[clarkepaul]

Yup good :)