Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhoneField. Add migration helpers from Linkable #48

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

chrispenny
Copy link
Collaborator

@chrispenny chrispenny commented Jul 14, 2022

  • Linkable had a concept of a "Phone" link, which didn't currently exist in LinkField. So I've added that. It's really just a duplicate of EmailField, but it returns a tel instead of a mailto.
  • Added some instructions based on what I found from migrating my own project. These steps may not be completely comprehensive, but I've tried to at least indicate areas that might need attention.
  • Supports Versioned and un-Versioned. However, we expect the Versioned state between legacy (Linkable) and LinkField to match.

@chrispenny chrispenny force-pushed the feature/linkable-migration-process branch 3 times, most recently from 80c9d9c to b1f403d Compare July 14, 2022 00:32
@chrispenny chrispenny force-pushed the feature/linkable-migration-process branch from b1f403d to 6ccd405 Compare July 14, 2022 00:36
@chrispenny chrispenny changed the title Add migration helpers from Linkable to LinkField Add PhoneField. Add migration helpers from Linkable Jul 14, 2022
@chrispenny chrispenny marked this pull request as ready for review July 14, 2022 01:19
@GuySartorelli
Copy link
Member

The migration stuff feels quite separate to the phone link functionality. Might be worth splitting it up into two PRs?

@chrispenny
Copy link
Collaborator Author

@GuySartorelli yea, you're right, it's just that the Phone PR would be a blocker for the migration stuff.

I figured this way, if anyone is looking in, needing to perform a migration soon, then they could choose to run this branch as a fork and have everything they need.

Chris Penny and others added 2 commits July 15, 2022 07:08
Copy link
Collaborator

@mfendeksilverstripe mfendeksilverstripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍 Code is looking good, documentation is quite detailed and it works for me locally. I managed to migrate a bunch of links from my fixture.

Screen Shot 2022-10-28 at 8 17 40 AM

I added some very minor changes:

  • WS fixes
  • added a few doc-blocks
  • renamed a few variables (avoid type in variable name)
  • simplified a few DB method calls
  • opened up some properties / methods to be protected (more flexibility in case someone needs to subclass)

@GuySartorelli GuySartorelli deleted the feature/linkable-migration-process branch October 27, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants