Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: Suppress deprecation notice #47

Merged

Conversation

chrispenny
Copy link
Collaborator

@chrispenny chrispenny commented Jun 28, 2022

JsonSerializable has defined the return type of :mixed for the jsonSerialize() method. I don't think we can define this in our module until we support a minimum of PHP 8.1.

@chrispenny chrispenny force-pushed the bugfix/suppress-deprecation-warning branch 2 times, most recently from 65a31fd to 25aabe6 Compare June 28, 2022 20:22
@chrispenny chrispenny changed the title PHP 8.1: Suppress deprecation notice. Update travis testing PHP 8.1: Suppress deprecation notice Jun 29, 2022
@chrispenny chrispenny force-pushed the bugfix/suppress-deprecation-warning branch from b95b896 to 98e8da5 Compare June 29, 2022 19:30
@chrispenny chrispenny marked this pull request as ready for review June 29, 2022 20:05
Copy link
Collaborator

@mfendeksilverstripe mfendeksilverstripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrispenny chrispenny merged commit 636c679 into silverstripe:1 Jun 29, 2022
@chrispenny chrispenny deleted the bugfix/suppress-deprecation-warning branch June 29, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants