-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update namespace. Add table_name config to all models #39
Conversation
b391fbf
to
63cd7df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go with a less generic table names to prevent potential naming conflicts. I can definitely see table called Link
having a conflict especially if a project is migrating from another module. I added LinkFieldLink
prefix as the name of this module is LinkField
.
360dfb3
to
d8777a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrispenny The changes look good but it seems some of the functionality is broken because of this change. This is my test setup (TNZ core after updating namespace references):
- Block page with a TextBlock / ButtonLink
- I switcher the block to NOT be inline editable
- navigated to the block edit form
Expected:
Actual:
Maybe there are some class references in the React bundle as well?
@chrispenny Can you please check if you are able to save and retain link related changes? I can see that the UI now works but none of the changes I make are retained. Seems to be an issue on both inline edit and normal edit form cases. Create a link Hit save Link doesn't show up even after page reload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local and it's working fine 👍
thanks for contribution :)
@chrispenny Feel free to merge. |
Prefixed each with
Link_
to make it easier to find all relevant tables, but also becauseFileLink
is already used by framework.