NEW: Empty link title fallbacks to Page. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a56e351 to
e22a00d
Compare
chrispenny
reviewed
Oct 25, 2021
src/Models/SiteTreeLink.php
Outdated
| } | ||
|
|
||
| // Use page title as a default value in case CMS user didn't provide the title | ||
| $this->Title = $this->Page->Title; |
There was a problem hiding this comment.
@mfendeksilverstripe What would be your thoughts on us implementing a getTitle() method instead? This way, if the Page:$Title updated, we could have the Link title update as well.
The Page would already be loaded in memory in order to determine the Link, so I don't think there would be any performance impact?
There was a problem hiding this comment.
I think more extensibility here is a good idea 👍
|
@chrispenny I've added new changes based on your feedback, please review. |
chrispenny
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW: Empty link title fallbacks to Page
Fixes #34