Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Set extension hook implementation visibility to protected #287

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Extensions/FluentLinkExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class FluentLinkExtension extends Extension
{
public function updateCMSFields(FieldList $fields)
protected function updateCMSFields(FieldList $fields)
{
$this->removeTabsWithFluentGridfields($fields);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/UsedOnTableExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

class UsedOnTableExtension extends Extension
{
public function updateUsageAncestorDataObjects(array &$ancestorDataObjects, DataObject $dataObject): void
protected function updateUsageAncestorDataObjects(array &$ancestorDataObjects, DataObject $dataObject): void
{
if (!is_a($dataObject, FileLink::class)) {
return;
Expand Down
2 changes: 1 addition & 1 deletion src/Models/Link.php
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function getVersionedState(): string
return 'unversioned';
}

public function onBeforeWrite(): void
protected function onBeforeWrite(): void
{
// Ensure a Sort value is set and that it's one larger than any other Sort value for
// this owner relation so that newly created Links on MultiLinkField's are properly sorted
Expand Down
2 changes: 1 addition & 1 deletion tests/php/Extensions/ExternalLinkExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

class ExternalLinkExtension extends DataExtension implements TestOnly
{
public function updateDefaultLinkTitle(&$defaultLinkTitle): void
protected function updateDefaultLinkTitle(&$defaultLinkTitle): void
{
$defaultLinkTitle = sprintf('External Link: %s', $this->owner->getURL());
}
Expand Down
Loading