Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Icon alignment #220

Merged
merged 1 commit into from
Feb 13, 2024
Merged

ENH Icon alignment #220

merged 1 commit into from
Feb 13, 2024

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Feb 13, 2024 •
edited
Loading

@sabina-talipova sabina-talipova mentioned this pull request Feb 13, 2024
Closed
GuySartorelli
GuySartorelli requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New alignment looks good in chrome but doesn't work for firefox.

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 13, 2024 •
edited
Loading

That said, don't spend too long on this - it's a super low priority. If it starts looking like it'll take a while just dump it in the icebox.

@sabina-talipova
Copy link
Contributor Author

Now should looks better.

Chrome:

Screenshot 2024-02-14 at 12 22 15 PM

Firefox:

Screenshot 2024-02-14 at 12 19 35 PM

Screenshot 2024-02-14 at 12 25 52 PM

GuySartorelli
GuySartorelli approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on green

@GuySartorelli GuySartorelli merged commit 848f532 into silverstripe:4 Feb 13, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/icon-alignement branch February 13, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli