Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Link type icon #170

Merged
merged 1 commit into from
Jan 14, 2024
Merged

NEW Link type icon #170

merged 1 commit into from
Jan 14, 2024

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Jan 11, 2024 •
edited
Loading

Description

Screenshot 2024-01-12 at 12 09 39 PM

Note

Probably, we should have special icons for link types, especially for Phone link and File Link . Currently, icons from general Silverstripe library were used.

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/4/link-icon branch 4 times, most recently from b8c9ab9 to ab48cc6 Compare January 12, 2024 02:33
@sabina-talipova sabina-talipova marked this pull request as ready for review January 12, 2024 02:41
@sabina-talipova sabina-talipova mentioned this pull request Jan 14, 2024
Closed
GuySartorelli
GuySartorelli requested changes Jan 14, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally, just a couple of small changes.

GuySartorelli
GuySartorelli approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bd31e3a into silverstripe:4 Jan 14, 2024
@GuySartorelli GuySartorelli deleted the pulls/4/link-icon branch January 14, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli